-
Notifications
You must be signed in to change notification settings - Fork 216
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #244 from allevato/distributed-let
Improve pattern recognition in `UseLetInEveryBoundCaseVariable`.
- Loading branch information
Showing
2 changed files
with
146 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
115 changes: 102 additions & 13 deletions
115
Tests/SwiftFormatRulesTests/UseLetInEveryBoundCaseVariableTests.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,115 @@ | ||
import SwiftFormatRules | ||
|
||
final class UseLetInEveryBoundCaseVariableTests: LintOrFormatRuleTestCase { | ||
func testInvalidLetBoundCase() { | ||
override func setUp() { | ||
super.setUp() | ||
self.shouldCheckForUnassertedDiagnostics = true | ||
} | ||
|
||
func testSwitchCase() { | ||
let input = | ||
""" | ||
switch DataPoint.labeled("hello", 100) { | ||
case let .labeled(label, value): | ||
break | ||
case let .labeled(label, value): break | ||
case .labeled(label, let value): break | ||
case .labeled(let label, let value): break | ||
case let .labeled(label, value)?: break | ||
case let .labeled(label, value)!: break | ||
case let .labeled(label, value)??: break | ||
case let (label, value): break | ||
case let x as SomeType: break | ||
} | ||
""" | ||
performLint(UseLetInEveryBoundCaseVariable.self, input: input) | ||
|
||
switch DataPoint.labeled("hello", 100) { | ||
case .labeled(label, let value): | ||
break | ||
} | ||
XCTAssertDiagnosed(.useLetInBoundCaseVariables, line: 2, column: 6) | ||
XCTAssertDiagnosed(.useLetInBoundCaseVariables, line: 5, column: 6) | ||
XCTAssertDiagnosed(.useLetInBoundCaseVariables, line: 6, column: 6) | ||
XCTAssertDiagnosed(.useLetInBoundCaseVariables, line: 7, column: 6) | ||
XCTAssertDiagnosed(.useLetInBoundCaseVariables, line: 8, column: 6) | ||
} | ||
|
||
switch DataPoint.labeled("hello", 100) { | ||
case .labeled(let label, let value): | ||
break | ||
} | ||
func testIfCase() { | ||
let input = | ||
""" | ||
if case let .labeled(label, value) = DataPoint.labeled("hello", 100) {} | ||
if case .labeled(label, let value) = DataPoint.labeled("hello", 100) {} | ||
if case .labeled(let label, let value) = DataPoint.labeled("hello", 100) {} | ||
if case let .labeled(label, value)? = DataPoint.labeled("hello", 100) {} | ||
if case let .labeled(label, value)! = DataPoint.labeled("hello", 100) {} | ||
if case let .labeled(label, value)?? = DataPoint.labeled("hello", 100) {} | ||
if case let (label, value) = DataPoint.labeled("hello", 100) {} | ||
if case let x as SomeType = someValue {} | ||
""" | ||
performLint(UseLetInEveryBoundCaseVariable.self, input: input) | ||
XCTAssertDiagnosed(.useLetInBoundCaseVariables) | ||
XCTAssertNotDiagnosed(.useLetInBoundCaseVariables) | ||
|
||
XCTAssertDiagnosed(.useLetInBoundCaseVariables, line: 1, column: 9) | ||
XCTAssertDiagnosed(.useLetInBoundCaseVariables, line: 4, column: 9) | ||
XCTAssertDiagnosed(.useLetInBoundCaseVariables, line: 5, column: 9) | ||
XCTAssertDiagnosed(.useLetInBoundCaseVariables, line: 6, column: 9) | ||
XCTAssertDiagnosed(.useLetInBoundCaseVariables, line: 7, column: 9) | ||
} | ||
|
||
func testGuardCase() { | ||
let input = | ||
""" | ||
guard case let .labeled(label, value) = DataPoint.labeled("hello", 100) else {} | ||
guard case .labeled(label, let value) = DataPoint.labeled("hello", 100) else {} | ||
guard case .labeled(let label, let value) = DataPoint.labeled("hello", 100) else {} | ||
guard case let .labeled(label, value)? = DataPoint.labeled("hello", 100) else {} | ||
guard case let .labeled(label, value)! = DataPoint.labeled("hello", 100) else {} | ||
guard case let .labeled(label, value)?? = DataPoint.labeled("hello", 100) else {} | ||
guard case let (label, value) = DataPoint.labeled("hello", 100) else {} | ||
guard case let x as SomeType = someValue else {} | ||
""" | ||
performLint(UseLetInEveryBoundCaseVariable.self, input: input) | ||
|
||
XCTAssertDiagnosed(.useLetInBoundCaseVariables, line: 1, column: 12) | ||
XCTAssertDiagnosed(.useLetInBoundCaseVariables, line: 4, column: 12) | ||
XCTAssertDiagnosed(.useLetInBoundCaseVariables, line: 5, column: 12) | ||
XCTAssertDiagnosed(.useLetInBoundCaseVariables, line: 6, column: 12) | ||
XCTAssertDiagnosed(.useLetInBoundCaseVariables, line: 7, column: 12) | ||
} | ||
|
||
func testForCase() { | ||
let input = | ||
""" | ||
for case let .labeled(label, value) in dataPoints {} | ||
for case .labeled(label, let value) in dataPoints {} | ||
for case .labeled(let label, let value) in dataPoints {} | ||
for case let .labeled(label, value)? in dataPoints {} | ||
for case let .labeled(label, value)! in dataPoints {} | ||
for case let .labeled(label, value)?? in dataPoints {} | ||
for case let (label, value) in dataPoints {} | ||
for case let x as SomeType in {} | ||
""" | ||
performLint(UseLetInEveryBoundCaseVariable.self, input: input) | ||
|
||
XCTAssertDiagnosed(.useLetInBoundCaseVariables, line: 1, column: 10) | ||
XCTAssertDiagnosed(.useLetInBoundCaseVariables, line: 4, column: 10) | ||
XCTAssertDiagnosed(.useLetInBoundCaseVariables, line: 5, column: 10) | ||
XCTAssertDiagnosed(.useLetInBoundCaseVariables, line: 6, column: 10) | ||
XCTAssertDiagnosed(.useLetInBoundCaseVariables, line: 7, column: 10) | ||
} | ||
|
||
func testWhileCase() { | ||
let input = | ||
""" | ||
while case let .labeled(label, value) = iter.next() {} | ||
while case .labeled(label, let value) = iter.next() {} | ||
while case .labeled(let label, let value) = iter.next() {} | ||
while case let .labeled(label, value)? = iter.next() {} | ||
while case let .labeled(label, value)! = iter.next() {} | ||
while case let .labeled(label, value)?? = iter.next() {} | ||
while case let (label, value) = iter.next() {} | ||
while case let x as SomeType = iter.next() {} | ||
""" | ||
performLint(UseLetInEveryBoundCaseVariable.self, input: input) | ||
|
||
XCTAssertDiagnosed(.useLetInBoundCaseVariables, line: 1, column: 12) | ||
XCTAssertDiagnosed(.useLetInBoundCaseVariables, line: 4, column: 12) | ||
XCTAssertDiagnosed(.useLetInBoundCaseVariables, line: 5, column: 12) | ||
XCTAssertDiagnosed(.useLetInBoundCaseVariables, line: 6, column: 12) | ||
XCTAssertDiagnosed(.useLetInBoundCaseVariables, line: 7, column: 12) | ||
} | ||
} |