Will 510.0.0 be released?

[kkebo]

swift-5.10.0-RELEASE has been released recently, but it lacks various features and fixes that 509.0.0 had.

For example, it doesn't include #623.

So I'm wondering if 510.0.0 will be released with more changes than swift-5.10-RELEASE.

[allevato]

I'll be doing some cherry-picks into the 5.10 release branch before cutting a release. Expect this to happen in the next few days.

[kkebo]

Thank you for the information. I'm relieved to hear that. Should I close this issue?

[allevato]

It's fine to leave it open to track the release.

[ahoppen]

I just pushed 510.0.0: https://github.com/apple/swift-format/tree/510.0.0

[kkebo]

@ahoppen @allevato

swift-format 510.0.0 is the same commit hash as swift-5.10-RELEASE, so it's still broken.

I'll be doing some cherry-picks into the 5.10 release branch before cutting a release.

It seems that you didn't do that after all.

For example, swift-format 510.0.0 and 510.0.1 will format the following code:

let a = 0
print(consume a)

into the following one:

let a = 0
print(consumea)

swift-format 509.0.0 has no such issue because it has already been fixed in #623. swift-format 510.0.x doesn't include it. This is a regression.

[allevato]

So that's my fault. Older versions of swift-format had more flexibility in being able to cherry-pick late into the release cycle because it wasn't bundled with the released toolchains. Now that it is, we have to be more restrictive about what kinds of changes are cherry-picked into the release branch because they can affect the toolchain builds on swift.org. The 5.10 branch was cut fairly early, and I wasn't prepared for it.

I'm discussing with @ahoppen the best way forward; I'm hopeful that we can just cut a new branch that's separate from the official release branch, pick all the important changes into it, and then do a dot release from there.

[kkebo]

Thank you for sharing the detailed information. I agree with that way of proceeding.

[ahoppen]

I just tagged 510.1.0, which should contain the fixes that were present in 509.0.0 but not 510.0.1