Support tab based indentation in the whitespace linter. #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allevato
approved these changes
Dec 5, 2019
| /// Returns a string that describes the indentation in a human readable format, which is | ||
| /// appropriate for use in diagnostic messages. | ||
| var diagnosticDescription: String { | ||
| switch(self) { |
There was a problem hiding this comment.
Remove parens around the switch argument here, and two (I think) places below please 🙂 (We should have a rule!)
There was a problem hiding this comment.
Done. The existing rule handled it; I just forgot to run the formatter. 😅
The linter was crashing whenever it encountered a tab because it only expected spaces to be used for whitespace. The linter now supports a wider range of whitespace characters and allows using tabs for indentation. This includes some revisions to the error messages to add tabs are as a suggestion for adding/removing indentation. There is also a new error message used when tabs (or really any non-space) characters are used for spacing (i.e. the whitespace that isn't indentation). SR-11211
dylansturg
force-pushed
the
handle_more_whitespace
branch
from
63c02b0
to
02538eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linter was crashing whenever it encountered a tab because it only expected spaces to be used for whitespace. The linter now supports a wider range of whitespace characters and allows using tabs for indentation. This includes some revisions to the error messages to add tabs are as a suggestion for adding/removing indentation. There is also a new error message used when tabs (or really any non-space) characters are used for spacing (i.e. the whitespace that isn't indentation).
SR-11211