Don't break before [ or { in single argument (labeled) function calls.
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alls. This change is like the one in commit 82e3e16, but allows the line break to be omitted if you have a function call with a single labeled argument whose value is an array/dictionary/closure literal. Getting this to work ended up revealing a couple other bugs around the way open breaks were handled. Previously, they *unconditionally* increased the indentation level of their scope, which meant that if one break didn't fire but another on the same line did, then the next line would be indented *two* units from the previous line instead of one. Now, an open break only contributes to indentation if it is not followed by another one on the same line. As a consequence of this, closure literal handling changed slightly. The changes were positive ones, allowing certain short closure literals to be formatted more compactly than the previous algorithm allowed. Fixes SR-11106.
akyrtzi
approved these changes
Jul 26, 2019
This was referenced Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is like the one in commit 82e3e16, but allows the line break to be omitted if you have a function call with a single labeled argument whose value is an array/dictionary/closure literal.
Getting this to work ended up revealing a couple other bugs around the way open breaks were handled. Previously, they unconditionally increased the indentation level of their scope, which meant that if one break didn't fire but another on the same line did, then the next line would be indented two units from the previous line instead of one. Now, an open break only contributes to indentation if it is not followed by another one on the same line.
As a consequence of this, closure literal handling changed slightly. The changes were positive ones, allowing certain short closure literals to be formatted more compactly than the previous algorithm allowed.
Fixes SR-11106.