Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swift-format for renamed children in SwiftSyntax #562

Merged
merged 1 commit into from Jul 23, 2023

Conversation

ahoppen
Copy link
Contributor

@ahoppen ahoppen commented Jul 11, 2023

Fix warnings in swift-format due to renames of syntax children and make changes so it compiles with apple/swift-syntax#1896.

@Matejkob
Copy link
Contributor

I believe apple/swift-syntax#1842 also introduced changes casing warnings in this repo. Are you gonna fix these warnings too? Or can I submit another PR with fixes?

@ahoppen
Copy link
Contributor Author

ahoppen commented Jul 13, 2023

@Matejkob If you could open a PR to fix the eof warnings, that would be very appreciated.

@Matejkob
Copy link
Contributor

It turned out that there is a bit more warning about using deprecated names. I've fixed them all in #567. I hope that's find

@ahoppen
Copy link
Contributor Author

ahoppen commented Jul 14, 2023

Thank you!

@ahoppen ahoppen force-pushed the ahoppen/naming-improvements branch from 4091de2 to fa54d14 Compare July 17, 2023 16:10
@ahoppen ahoppen force-pushed the ahoppen/naming-improvements branch from fa54d14 to bee97be Compare July 22, 2023 04:39
@ahoppen ahoppen merged commit 6aa70af into apple:main Jul 23, 2023
@ahoppen ahoppen deleted the ahoppen/naming-improvements branch July 23, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants