Move the default Configuration.init() into a separate file.
#580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is meant to make it easier for users forking or building their own swift-format to change the hardcoded default configuration. This also adds a helper for the default test configuration. We can't let the unit tests rely on the default configuration because that would make the tests fail when run with a swift-format binary that has a different default configuration. This approach lets the default test configuration differ from the "real" default configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to make it easier for users forking or building their own swift-format to change the hardcoded default configuration.
This also adds a helper for the default test configuration. We can't let the unit tests rely on the default configuration because that would make the tests fail when run with a swift-format binary that has a different default configuration. This approach lets the default test configuration differ from the "real" default configuration.