Collapse almost everything into a single SwiftFormat module.
#593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move `Core`, `PrettyPrint`, `Rules`, and `WhitespaceLinter` tests into subdirectories of a new `SwiftFormatTests` target. (`WhitespaceLinter` is folded into the `PrettyPrint` subdirectory.)
This indicates that it should not be used by users. (In the future, it should use `package` access-level declarations.)
…dules into `SwiftFormat`. This only moves files and updated imports; access level changes and SPIs will be introduced later.
These changes are only the ones that don't cause compilation errors.
These are part of the public API; they were originally in `SwiftFormatCore` but reexported by `SwiftFormat`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically swift-format has been internally split into many modules—Core, Rules, PrettyPrint, WhitespaceLinter. These were implementation details, and
SwiftFormatis the only module that provides public API that users should import. There's not much advantage to having this structure, and (until we start using thepackageaccess level at some point), this leaked implementation details aspublicdeclarations.This PR reorganizes everything so there are only two primary modules:
SwiftFormatConfiguration(unchanged from before), andSwiftFormat(everything else).@_spiis used where needed to make certain declarations visible to tests (or togenerate-pipeline) but keep them otherwise hidden from normal clients.