Add support to define a default target in manifest file #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -805,6 +807,15 @@ bool BuildSystemImpl::build(StringRef target) { | |||
| // Create the execution queue. | |||
| executionQueue = delegate.createExecutionQueue(); | |||
|
|
|||
| // If target name is not passed then we try to load the default target name | |||
| // from manifest file | |||
| if (target.size() < 1) { | |||
There was a problem hiding this comment.
You can use target.empty() (and likewise two lines below).
|
Looks great, can we get a test case and an update the the docs on the manifest file format ( |
|
@ddunbar done |
|
|
||
| The default target to build can be specified by including an entry for the | ||
| empty string (`""`). | ||
| This section defines default target to build when manifest is loaded. |
ankitspd
force-pushed
the
default-target
branch
from
bb1f7d9
to
3b438f0
Compare
|
LGTM, squash and merge away! Thanks! |
ankitspd
force-pushed
the
default-target
branch
from
3b438f0
to
08aed6a
Compare
|
squashed, weirdly don't have merge access in this repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.swift.org/browse/SR-1173