[BuildSystem] Move Swift compiler's aux files next to the object file #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is important for performing correct builds when there are two source files with the same name in a Swift target. <rdar://problem/41060279> Nest all swift auxiliary files similar to the object files
|
@swift-ci smoke test |
jrose-apple
approved these changes
Jul 30, 2018
|
Not sure if we can create a future proof test as the "failure" depends on the type of supplementary file. |
|
I guess it would be hardcoding knowledge of the file map format, but you could check that no paths are duplicated throughout the file. (Honestly, the compiler could probably check that too, so maybe you should just file a JIRA bug and leave it at that.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is important for performing correct builds when there are two source files
with the same name in a Swift target.
rdar://problem/41060279 Nest all swift auxiliary files similar to the object files