[Ninja] Add support for Ninja 1.6 style rule scoping. #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
- https://bugs.swift.org/browse/SR-2858 - <rdar://problem/28616636> [SR-2858] llbuild Ninja support doesn't handle rules in subninja scope
ddunbar
force-pushed
the
Ninja-Add-support-for-Ninja-1.6-style-rule-scoping
branch
from
f6b66db
to
baaf51a
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
dmbryson
approved these changes
Jul 13, 2019
|
@swift-ci please smoke test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.swift.org/browse/SR-2858
rdar://problem/28616636 [SR-2858] llbuild Ninja support doesn't handle rules in subninja scope
Depends on [Ninja] Rename BindingSet to Scope. #506