Shim llvm::sys::getDefaultTargetTriple() to Swift #572
Conversation
The default target triple for the host machine can be useful information when constructing command line arguments for a tool, but this information isn’t in LLVM’s C API, so it’s inaccessible from Swift. This commit exposes it in libllbuild as `llb_get_default_target_triple()` and in llbuildSwift as `BuildSystem.defaultTargetTriple`.
|
@swift-ci please smoke test |
|
|
||
| const char * llb_get_default_target_triple() { | ||
| // Use a static local to store the triple, to avoid lifetime issues. | ||
| static std::string tripleString = llvm::sys::getDefaultTargetTriple(); |
There was a problem hiding this comment.
does this really work? LLVM goes to some extreme lengths to determine the default triple. I am not sure if llbuild does that as well.
There was a problem hiding this comment.
I'm not quite sure what you mean. This ends up using the exact same code that would be called in the clang or Swift drivers. That code does sometimes invoke external tools or perform other heroics to determine the OS version, but all of that code looks like it's intended to be idempotent, so caching the result ought not to cause any problems.
There was a problem hiding this comment.
I meant if the copy in llbuild actually does the heroics done by llvm. I checked and it seems like this is filled in at compile time using LLVM_DEFAULT_TARGET_TRIPLE defined to empty string in llbuild: https://github.com/apple/swift-llbuild/blob/master/include/llvm/Config/config.h#L356
There was a problem hiding this comment.
Damn, you're right. Is there a particular reason we do this, or is it just because we haven't wanted this until now?
|
Looks like this won't work without a larger change to the way we configure llbuild. |
The default target triple for the host machine can be useful information when constructing command line arguments for a tool, but this information isn’t in LLVM’s C API, so it’s inaccessible from Swift. This commit exposes it in libllbuild as
llb_get_default_target_triple()and in llbuildSwift asBuildSystem.defaultTargetTriple.