Provide capability for clients to build a node and walk the rule result info for the node and its dependencies #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
|
@swift-ci smoke test OS X platform |
akyrtzi
force-pushed
the
walk-built-nodes-67816715
branch
2 times, most recently
from
bc15d6a
to
b4d3c1e
Compare
|
@swift-ci smoke test |
…lt info for the node and its dependencies This is implemented by having the client optionally pass an implementation of a `RuleResultsWalker` which receives the related information for the nodes. I preferred this method of allowing the client to "hook" in and get the info before the `build` call returns and does its clean up and any related "teardown". That way we ensure the data is readily available for the client to inspect. This method also allows to restrict the rule result queries only to the nodes related to the just built node, which simplifies things compared to exposing general APIs for querying any node, even if it wasn't involved in the build. Related to rdar://67816715
akyrtzi
force-pushed
the
walk-built-nodes-67816715
branch
from
b4d3c1e
to
3f785b6
Compare
|
@swift-ci smoke test |
|
I am not sure about this, as a direction... I’d like to understand what the motivation and trade offs are here before tackling this at a PR review level. Do you have a high level proposal of what and why? |
|
The Swift project moved the default branch to More detail about the branch update - https://forums.swift.org/t/updating-branch-names/40412 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implemented by having the client optionally pass an implementation of a
RuleResultsWalkerwhich receives the related information for the nodes.I preferred this method of allowing the client to "hook" in and get the info before the
buildcall returns and does its clean up and any related "teardown".That way we ensure the data is readily available for the client to inspect.
This method also allows to restrict the rule result queries only to the nodes related to the just built node, which simplifies things compared to exposing general APIs for querying any node, even if it wasn't involved in the build.
Related to rdar://67816715