Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BuildDB] Lock db connection #829

Closed
wants to merge 1 commit into from
Closed

Conversation

dmbryson
Copy link
Collaborator

When the sqlite3 threading mode is 'serialized', sqlite3_errcode and
sqlite3_errmsg may be stomped on by concurrent use. Per the
documentation, threads should obtain exclusive use via
sqlite3_db_mutex to ensure consistency of these values.

rdar://problem/60378054

When the sqlite3 threading mode is 'serialized', `sqlite3_errcode` and
`sqlite3_errmsg` may be stomped on by concurrent use. Per the
documentation, threads should obtain exclusive use via
`sqlite3_db_mutex` to ensure consistency of these values.

rdar://problem/60378054
@dmbryson dmbryson requested a review from ddunbar as a code owner June 14, 2022 16:23
@dmbryson
Copy link
Collaborator Author

@swift-ci please smoke test

@dmbryson
Copy link
Collaborator Author

0  llbuild         0x000000000049bf95
1  llbuild         0x000000000049b41c
2  llbuild         0x000000000049c64b
3  libpthread.so.0 0x00007fb7b6cae3c0
4  libsqlite3.so.0 0x00007fb7b707b3a4 sqlite3_db_mutex + 4
5  llbuild         0x000000000047baf2
6  llbuild         0x000000000046dc1d
7  llbuild         0x0000000000422b7b
8  llbuild         0x0000000000413d54
9  llbuild         0x000000000040b1df
10 libc.so.6       0x00007fb7b6acc0b3 __libc_start_main + 243
11 llbuild         0x000000000040a53e

note: command had no output on stdout or stderr
error: command failed with exit status: -11

😱

@shahmishal
Copy link
Member

@swift-ci test

@shahmishal
Copy link
Member

Testing Time: 10.27s
  Unsupported      :  11
  Passed           : 121
  Expectedly Failed:   1
  Failed           : 101

@dmbryson dmbryson closed this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants