Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply changes to use posix_spawn_file_actions_addchdir_np on macOS #876

Merged
merged 3 commits into from Apr 25, 2023

Conversation

owenv
Copy link
Contributor

@owenv owenv commented Apr 25, 2023

The deployment target issues which lead to the initial revert several years back are no longer a concern. Reapply these changes, so that when spawning tasks we're making less use of global state.

@owenv
Copy link
Contributor Author

owenv commented Apr 25, 2023

@swift-ci please smoke test

@owenv
Copy link
Contributor Author

owenv commented Apr 25, 2023

@swift-ci please smoke test

@airspeedswift airspeedswift self-requested a review April 25, 2023 16:00
@owenv
Copy link
Contributor Author

owenv commented Apr 25, 2023

Pushed to amend a buggy test

@owenv
Copy link
Contributor Author

owenv commented Apr 25, 2023

@swift-ci please smoke test

@owenv
Copy link
Contributor Author

owenv commented Apr 25, 2023

@swift-ci please smoke test

@owenv
Copy link
Contributor Author

owenv commented Apr 25, 2023

@swift-ci please test Windows platform

@owenv owenv merged commit af56834 into apple:main Apr 25, 2023
3 checks passed
@owenv owenv deleted the pr/ovoorhees/108481945 branch April 25, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants