This repository has been archived by the owner on Apr 2, 2020. It is now read-only.
normalize test file extension for test filenames #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like something changed so that a test's filename can report as the .pyc rather than the .py file in some flows. This causes confusion, particularly in cases where a test runner queue has to synthesize a test event, uses the .py extension that we always used. Then the rerun result event has a different key than the timeout test run, and the timeout test run does not get overwritten. This change introduces a normalization step that convers all test filenames ending in .pyc to end in .py. Fixes: https://bugs.swift.org/browse/SR-1220
|
@swift-ci Please test Linux platform |
|
Merging this in - this is a fix for the test running infrastructure. I hit the same failing tests locally, but these are now due to the Swift #line/#sourceLocation change. I don't blame anyone for not catching that given all the noise that the LLDB test suite was generating. |
rintaro
pushed a commit
to rintaro/swift-lldb
that referenced
this pull request
Jul 29, 2016
posix sem_timedwait requires epoch-based timeout
rintaro
pushed a commit
to rintaro/swift-lldb
that referenced
this pull request
Jul 29, 2016
posix sem_timedwait requires epoch-based timeout Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something changed so that a test's filename can
report as the .pyc rather than the .py file in some flows. This
causes confusion, particularly in cases where a test runner
queue has to synthesize a test event, which uses the .py extension that everything was previously using. Then the rerun result event has a different
key than the timeout test run, and the timeout test run does
not get overwritten.
This change introduces a normalization step that converts all
test filenames ending in .pyc to end in .py.
Fixes:
https://bugs.swift.org/browse/SR-1220