better abstration for LoggingSystem state #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: prepare for sendable checks changes: * abstract the LoggingSystem state into a "boxed" class that handles the locking * adjust call sites
tomerd
force-pushed
the
refactor/logger-system
branch
from
cb36592
to
d2a43ff
Compare
weissi
reviewed
Jun 28, 2022
Sources/Logging/Logging.swift
Outdated
| } | ||
|
|
||
| func replaceFactory(_ factory: @escaping (String) -> LogHandler, validate: Bool) { | ||
| #if canImport(WASILibc) |
There was a problem hiding this comment.
shouldn't we push that into the ReaderWriterLock and just do nothing in WASI?
There was a problem hiding this comment.
l kept this "as is" based on the comment in L676: https://github.com/apple/swift-log/pull/222/files#diff-f5985f666e1e706d02b520068f87ee07c97e376122fbd685314e088e0d532bb0R676
There was a problem hiding this comment.
Yeah, but we can just put the do-nothing code into the ReaderWriterLock. That has less logic and is already #if-def'd for Windows etc already, right?
Merged
tomerd
added
the
patch-version-bump-only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: prepare for sendable checks (they dont work well with static state)
changes: