New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a CocoaPods podspec generator #54
Conversation
88452ee
to
5741d31
Compare
5741d31
to
1021e23
Compare
Please see below my feedback:
|
Oh thanks! Would you mind checking if it works? I have no idea how to build a Watch app :)
Could do that, or maybe |
|
A bit unfortunate with the module name already occupied hm... |
1021e23
to
6a1a52d
Compare
@tanner0101 you also fine with pod name |
6a1a52d
to
7400e10
Compare
7400e10
to
1359044
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
(opinion on package name == neutral... people who actively use CocoaPods would have opinions / ideas I guess)
Why is the iOS/tvOS deployment target 12 and macOS 10.14? Are there any unavailable APIs in use? (I'm currently using all this source deploying to iOS 11) In fact, I can compile all the way down to iOS 8 :-) |
Very happy to relax the version here if you tell me what the lowest version is that you could confirm actually working. |
@weissi I'll report back shortly |
@weissi Here is a git repo that has a rather large set of Apple targets. It uses a local version of the podspec with the following deployment targets:
iOS, tvOS, and watchOS are informed by Xcode 10.2's minimums that the GUI allows. macOS is 10.9 because Swift isn't supported with a lower deployment target. I did not actually test on the old platforms running these versions as that could be a rather complicated endeavor. The key thing is that it compiles correctly with these deployment targets. If users actually have issues with running on those older platform versions, that'll be the most informative to any other changes I'd think. I did verify functionality on all the latest simulators as well as my mac @ 10.14. |
Also wanted to mention there was a lot of conversation about the Pod name being |
1359044
to
0a4743d
Compare
Thank you so much! I updated this PR, please check :).
I mean we can also name the pod |
A bit hard for me to comment on package naming -- don't know that ecosystem very well... whichever you think works best 👍 |
In the pods ecosystem, having module names match the pod names is pretty common if it's possible. It actually took me a few minutes to realize I shouldn't be doing |
@weissi I believe it is better to use Logging as package name. It will lock the name to prevent other lib use this general name. Sorry for the late comment. |
Thanks @shuoli84 . @tomerd / @ianpartridge okay with making the CocoaPod just |
Fine by me. Really hope we don't have to do CocoaPods for very long! |
0a4743d
to
99ea1a1
Compare
@ianpartridge thanks, I updated the PR to use |
no strong feeling here, but is it worth reaching out to the owner of SwiftLog pod and see if he wants to work with us on this |
@daltoniam ^^ |
Motivation: Users ask for a CocoaPod. Unfortunately, the CocodPod `SwiftLog` is already taken, so I went for `SwiftLogAPI`. Modification: Add a podspec generator. Result: Happier users.
99ea1a1
to
970c1aa
Compare
@tomerd the |
yes, lets do that |
Motivation:
Users ask for a CocoaPod. Unfortunately, the CocodPod
SwiftLog
isalready taken, so I went for
SwiftLogAPI
.Modification:
Add a podspec generator.
Result:
Example output: