Link to ianpartridge/swift-log-syslog backend impl #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ianpartridge implemented a backend for syslog (awesome :-)) so we should link to it so people are easily able to discover it (and any other future implementations we'd want to link to). The style of this section closely follows swift metrics, where we also have a section about "existing backends." Sounds good to add like this @ianpartridge or should we reword somehow? // cc @tomerd @weissi
ktoso
commented
May 20, 2019
| @@ -6,7 +6,7 @@ First things first: This is the beginning of a community-driven open-source proj | |||
|
|
|||
| What `SwiftLog` provides today can be found in the [API docs][api-docs]. | |||
|
|
|||
| ## Great, what's the tl;dr | |||
| ## Getting started | |||
There was a problem hiding this comment.
Aligning wording style between sswg repos (a bit too casual for a h2 I thought...), sounds good?
ktoso
commented
May 20, 2019
| @@ -54,6 +54,13 @@ LoggingSystem.bootstrap(StreamLogHandler.standardError) | |||
|
|
|||
| For further information, please check the [API documentation][api-docs]. | |||
|
|
|||
| #### Selecting a logging backend implementation (applications only) | |||
There was a problem hiding this comment.
Following the style of https://github.com/apple/swift-metrics#selecting-a-metrics-backend-implementation-applications-only and right after the default logger behavior is described; seems like a good spot for this
README.md
Outdated
|
|
||
| As the API has just launched, not many implementations exist yet. If you are interested in implementing one see the "Implementation considerations" section below explaining how to do so. List of existing SwiftLog API compatible libraries: | ||
|
|
||
| - [ianpatridge/swift-log-**syslog**](https://github.com/ianpartridge/swift-log-syslog) – a [syslog](https://en.wikipedia.org/wiki/Syslog) backend, |
There was a problem hiding this comment.
patridge -> partridge
There was a problem hiding this comment.
Whoops, terribly sorry about this 🙇 Fixing right away.
weissi
reviewed
May 20, 2019
weissi
requested changes
May 20, 2019
Co-Authored-By: Johannes Weiss <johannesweiss@apple.com>
|
Sorry about the typo @ianpartridge, fixed :-) Merge at will. |
tomerd
approved these changes
May 20, 2019
|
thanks @ktoso |
tomerd
added
the
patch-version-bump-only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ianpartridge implemented a backend for syslog (awesome :-)) so we should link to it so people are easily able to discover it (and any other future implementations we'd want to link to).
The style of this section closely follows swift metrics, where we also have a section about "existing backends."
Sounds good to add like this @ianpartridge or should we reword somehow?
// cc @tomerd @weissi