test formatting issues as part of sanity check #84
Conversation
Sources/Logging/Logging.swift
Outdated
| let systemStderr = Glibc.stderr! | ||
| let systemStdout = Glibc.stdout! | ||
| let systemStderr = Glibc.stderr! | ||
| let systemStdout = Glibc.stdout! | ||
| #endif |
There was a problem hiding this comment.
nit / question: I was under the impression "official formatting" for #if is to not indent?
Either way, happy with having an automatted formatted so whichever we want is fine, just confused about this one.
There was a problem hiding this comment.
personally i don't have a strong opinion on concrete format rules. what we agreed on in the past is captured in the repo's .swiftformat file, so we can change it if we want to agree on a different set of rules
There was a problem hiding this comment.
Yeah same, though this one is surprising... curious if choice was conscious on the #ifs @weissi ? As mentioned, not an issue and LGTM as I'm more than happy to have automated formatter
There was a problem hiding this comment.
I'd go with whatever Xcode does just because it's a pain otherwise because it'll re-indent in the way it thinks it's right.
| } | ||
| set { | ||
| metadata[metadataKey] = newValue | ||
| self.metadata[metadataKey] = newValue |
|
/cc @ianpartridge |
| @@ -1,56 +1,35 @@ | |||
| ARG ubuntu_version=18.04 | |||
| FROM ubuntu:$ubuntu_version | |||
| ARG swift_version=5.0 | |||
motivaiton: unified format changes: * use official docker image 馃帀 * fix outstanding formatting issues * add a call to swiftformat as part of sanity script * fix sanity script language check debugging statements
tomerd
added
the
patch-version-bump-only
motivaiton: unified format
changes: