Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename main.swift to MarkdownCommand.swift and add @main #10

Merged
merged 4 commits into from Jul 14, 2023

Conversation

Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Nov 2, 2021

Bug/issue #, if applicable: Close #78

Summary

  • Rename main.swift to MarkdownCommand.swift to better reflect the file's content.
  • Adopt the @main feature of Swift.

Dependencies

It depends on min swift version to "5.4" to use executableTarget.
(When the time is appropriate/5.4 [released on April 26, 2021] is widely adopted, will convert it from draft PR into PR)

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Ran the ./bin/test script and it succeeded

@Kyle-Ye Kyle-Ye marked this pull request as ready for review July 13, 2023 15:21
@Kyle-Ye
Copy link
Collaborator Author

Kyle-Ye commented Jul 13, 2023

@swift-ci please test

@Kyle-Ye
Copy link
Collaborator Author

Kyle-Ye commented Jul 13, 2023

@swift-ci please test

// swift-tools-version:5.3
// In order to support users running on the latest Xcodes, please ensure that
// Package@swift-5.5.swift is kept in sync with this file.
// swift-tools-version:5.5
Copy link
Collaborator Author

@Kyle-Ye Kyle-Ye Jul 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is safe for us to bump to use Swift 5.5 now. (Released on SEPTEMBER 20, 2021)

@Kyle-Ye
Copy link
Collaborator Author

Kyle-Ye commented Jul 14, 2023

@swift-ci please test

@Kyle-Ye Kyle-Ye merged commit 07da205 into apple:main Jul 14, 2023
2 checks passed
@Kyle-Ye Kyle-Ye deleted the fix/main_refactor branch July 14, 2023 13:24
@Kyle-Ye Kyle-Ye mentioned this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Swift 5.3 Support
2 participants