Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in markdown-tool validation error #104

Merged
merged 2 commits into from Jul 14, 2023

Conversation

Samasaur1
Copy link
Contributor

Bug/issue #, if applicable: N/A

Summary

Fixes a typo in the bundled markdown-tool example command.

Dependencies

None

Testing

echo "" | swift run markdown-tool format --unordered-list-marker 1

now errors with the value passed as an option, not the unrelated value of emphasisMarker

Steps:

  1. Clone this PR/my repository
  2. Run the above command

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran the ./bin/test script and it succeeded
  • Updated documentation if necessary

There are no tests for the markdown-tool, so I didn't add any. The ./bin/test script failed for me on main, but I didn't cause any new issues. There is no documentation to update

@QuietMisdreavus
Copy link
Contributor

@swift-ci Please test

Copy link
Collaborator

@Kyle-Ye Kyle-Ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kyle-Ye
Copy link
Collaborator

Kyle-Ye commented Jul 13, 2023

@swift-ci please test

@Kyle-Ye Kyle-Ye merged commit f631ea6 into apple:main Jul 14, 2023
2 checks passed
@Kyle-Ye
Copy link
Collaborator

Kyle-Ye commented Jul 14, 2023

Thanks for the contribution.

@Samasaur1 Samasaur1 deleted the markdown-tool-validation-typo branch July 14, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants