Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash parsing document tree dump as markdown content #123

Merged
merged 1 commit into from Apr 24, 2023

Conversation

d-ronnqvist
Copy link
Contributor

Bug/issue #, if applicable: rdar://108281578

Summary

Fix a crash (String index range is out of bounds) when parsing a document tree dump followed by a one-line directive as markdown content. See test

Dependencies

None.

Testing

See the added test.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran the ./bin/test script and it succeeded
  • [ ] Updated documentation if necessary

@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test

Copy link

@daniel-grumberg daniel-grumberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@d-ronnqvist d-ronnqvist merged commit 40f7f85 into apple:main Apr 24, 2023
2 checks passed
d-ronnqvist added a commit to d-ronnqvist/swift-markdown that referenced this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants