Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add RewritingMetricsFactory
Motivation:
Sometimes we need rewrite the names of metrics or dimensions into different names. This could be, for example, to make metrics from a new system match what they were in an older system
Modifications:
Add a new
MetricsRewriter
protocol, which describes how to rewrite metricsAdd a new
RewritingMetricsHandler
, an implementation of MetricsFactory which takes aMetricsRewriter
and passes all metrics through itNotes
any MetricsFactory
. This is because I expect people to have a concrete type at startup when they would create this handler