Make HTTP type conversion code public #216
Conversation
| @@ -15,14 +15,14 @@ | |||
| import HTTPTypes | |||
| import NIOHTTP1 | |||
|
|
|||
| private enum HTTP1TypeConversionError: Error { | |||
| public enum HTTP1TypeConversionError: Error { | |||
There was a problem hiding this comment.
We have to do our usual struct wrapping enum dance here otherwise we can never evolve this enum in the future.
There was a problem hiding this comment.
Done.
I was wondering why NIO never implemented a func ~ for these errors so switch and catch pattern matching was simplified. Currently to catch one of these "struct" errors you need
} catch let e as HTTP1TypeConversionError where e == .invalidStatusCode {Which is a mouthful, and something I get wrong every time.
If this was added to allow pattern matching
public static func ~= (_ lhs: Self, _ rhs: Error) -> Bool {
guard let rhs = rhs as? Self else { return false }
return lhs == rhs
}The catch statement gets reduced to
} catch HTTP1TypeConversionError.invalidStatusCode {as if it is an enum.
There was a problem hiding this comment.
In general, we try to stay away from custom operators or overloading more operators since they have quite a heavy impact on the compiler's performance. What we really want is extensible enums in non-library evolution mode.
There was a problem hiding this comment.
What we really want is extensible enums in non-library evolution mode.
Been waiting for that one for a while.
There was a problem hiding this comment.
@FranzBusch Is there anything holding merging this now?
|
@swift-server-bot test this please |
|
Is this ready to merge? The API breakage CI seems stuck. |
|
@swift-server-bot test this please |
|
@yim-lee for some reason the API breakage pipeline is not starting can you check what's going wrong here? |
|
@swift-server-bot add to allowlist |
|
Just needed to add Adam to the allow list it seems. Should be ok now. |
|
The API breakage is complaining about As I haven't touched this file I'm not sure why I'm getting this. |
hamzahrmalik
added
the
🔼 needs-minor-version-bump
Make NIOHTTP1 -> HTTPTypes and vice versa conversion code public
Motivation:
WebSocket APIs still use NIOHTTP1 types which means any library that wants to use the new types has to write a conversion step. Also OpenAPI runtime uses new HTTP types while both the server transports that are published use old NIOHTTP1 types. It is probably better that there is one place where this conversion code lives.