Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform requirements #128

Closed
wants to merge 1 commit into from
Closed

Conversation

d-date
Copy link

@d-date d-date commented Aug 27, 2021

Add platform requirements to do release build in Apple platforms in Xcode 13.

Motivation:

In Xcode 13 beta, Swift libraries fail to build for iOS targets that use armv7.
This will affect to release build in Apple platforms.
Screen Shot 2021-08-27 at 13 14 42

We can reproduce this issue on running archive build on NIOTransportServices scheme.

Modifications:

As described in Xcode release note, just add platforms: in Package.swift.

Swift libraries may fail to build for iOS targets that use armv7. (74120874)
Workaround: Increase the platform dependency of the package to v12 or later.
https://developer.apple.com/documentation/xcode-release-notes/xcode-13-beta-release-notes

This is caused by using Network.framework so platforms versions are depends on Network.framework availability.
The platforms: attribute will be ignored in Linux or Server Side Swift.

Result:

Release build has succeeded.

@swift-server-bot
Copy link

Can one of the admins verify this patch?

4 similar comments
@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@glbrntt
Copy link
Contributor

glbrntt commented Aug 27, 2021

We can't accept this patch as changing platforms: will break existing users who support older platforms. As noted though, this is a known issue in a beta release which may be fixed in a subsequent Xcode version.

@glbrntt glbrntt closed this Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants