Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Linux test file generation script should use the correct dates. #1036

Closed
tigerpixel opened this issue Jun 16, 2019 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@tigerpixel
Copy link
Contributor

Expected behavior

When the Linux test generation script is run, it should use the correct dates for the copyright section of the files it creates. See the dates in the headers.

Actual behavior

When the Linux test generation script is run, it uses hard-coded dates. (generate_linux_tests.rb ln 39)

Steps to reproduce

  1. Look at any file generated by the Linux test script. (Any file with +XCTest at the end).

If possible, minimal yet complete reproducer code (or URL to code)

SwiftNIO version/commit hash

All

Swift & OS version (output of swift --version && uname -a)

All

Note: From @Lukasa "I think the right change is actually to check the git history for a given file and use the year of the last commit to the file, as well as the year of the first commit to the file, to maintain the date here."

@agnosticdev
Copy link
Contributor

Can this be closed now on the merge of #1894 ?

@Lukasa
Copy link
Contributor

Lukasa commented Jul 13, 2021

Yup!

@Lukasa Lukasa closed this as completed Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants