Commits on Mar 3, 2020

1. tests: improve tests that are supposed to throw …

   Motivation:
   
   The
   
       do {
           try someOperation()
   	XCTFail("should throw") // easy to forget
       } catch error as SomethingError {
           XCTAssertEqual(.something, error as? SomethingError)
       } catch {
           XCTFail("wrong error")
       }
   
   pattern is not only very long, it's also very error prone. If you forget
   any of the XCTFails, you might not tests what it looks like
   
       XCTAssertThrowsError(try someOperation) { error in
           XCTAssertEqual(.something, error as? SomethingError)
       }
   
   is much safer and shorter.
   
   Modifcations:
   
   Do many of the above replaces.
   
   Result:
   
   Cleaner, shorter, and safer tests.

   

   weissi committed Mar 3, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 27f7bdc
   • Browse repository at this point

   Copy the full SHA

   27f7bdc View commit details

   Browse the repository at this point in the history