Add support for unidirectional NIOPipeBootstrap
#2560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weissi
reviewed
Oct 18, 2023
|
Oh @FranzBusch let's also fix |
FranzBusch
force-pushed
the
fb-one-direction-pipe-channel
branch
from
f90a36b
to
1748c4e
Compare
FranzBusch
force-pushed
the
fb-one-direction-pipe-channel
branch
2 times, most recently
from
4172d79
to
55cae0a
Compare
weissi
reviewed
Oct 18, 2023
| @@ -22,7 +22,6 @@ internal struct OutputGrepper { | |||
|
|
|||
| internal static func make(group: EventLoopGroup) -> OutputGrepper { | |||
| let processToChannel = Pipe() | |||
| let deadPipe = Pipe() // just so we have an output... | |||
weissi
reviewed
Oct 18, 2023
weissi
reviewed
Oct 18, 2023
glbrntt
requested changes
Oct 19, 2023
FranzBusch
force-pushed
the
fb-one-direction-pipe-channel
branch
from
fde39a7
to
0e4ce99
Compare
glbrntt
reviewed
Oct 24, 2023
| @available(macOS 10.15, iOS 13, tvOS 13, watchOS 6, *) | ||
| func _takingOwnershipOfDescriptors<ChannelInitializerResult, PostRegistrationTransformationResult: Sendable>( | ||
| public func takingOwnershipOfDescriptor<Output: Sendable>( |
There was a problem hiding this comment.
Output is a bit misleading in light of input/output descriptors. Should we use "Result" or something super-generic?
There was a problem hiding this comment.
We are using Output in all the other methods some I am hesitant to change it just for this one. Also why do you suggest making this public?
There was a problem hiding this comment.
We are using
Outputin all the other methods some I am hesitant to change it just for this one.
Yeah, I get that, it's probably fine as is.
Also why do you suggest making this public?
I didn't, you made it public!
FranzBusch
force-pushed
the
fb-one-direction-pipe-channel
branch
from
0e4ce99
to
834cc75
Compare
glbrntt
approved these changes
Oct 24, 2023
# Motivation In some scenarios, it is useful to only have either an input or output side for a `PipeChannel`. This fixes apple#2444. # Modification This PR adds new methods to `NIOPipeBootstrap` that make either the input or the output optional. Furthermore, I am intentionally breaking the API for the new async methods since those haven't shipped yet to reflect the same API there. # Result It is now possible to bootstrap a `PipeChannel` with either the input or output side closed.
FranzBusch
force-pushed
the
fb-one-direction-pipe-channel
branch
from
834cc75
to
2a59e2d
Compare
FranzBusch
added
the
🔼 needs-minor-version-bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In some scenarios, it is useful to only have either an input or output side for a
PipeChannel. This fixes #2444.Modification
This PR adds new methods to
NIOPipeBootstrapthat make either the input or the output optional. Furthermore, I am intentionally breaking the API for the new async methods since those haven't shipped yet to reflect the same API there.Result
It is now possible to bootstrap a
PipeChannelwith either the input or output side closed.