Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update availability guard on tests #2739

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

gjcairo
Copy link
Contributor

@gjcairo gjcairo commented Jun 11, 2024

Some tests are currently broken because of unavailable APIs

Motivation:

We want tests to build.

Modifications:

Update availability guard

Result:

Tests build on all platforms

@@ -19,7 +19,7 @@ import NIOPosix
import NIOFoundationCompat
import XCTest

@available(macOS 10.15, iOS 13.0, watchOS 6.0, tvOS 13.0, *)
@available(macOS 10.15, iOS 15.0, watchOS 6.0, tvOS 13.0, *)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the right bump, is it just iOS affected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I was missing bumping the other platforms.

@glbrntt
Copy link
Contributor

glbrntt commented Jun 11, 2024

@swift-server-bot test this please

@glbrntt glbrntt enabled auto-merge (squash) June 11, 2024 17:21
@glbrntt glbrntt added the needs-no-version-bump For PRs that when merged do not need a bump in version number. label Jun 11, 2024
@glbrntt glbrntt merged commit 2b5d277 into apple:main Jun 11, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-no-version-bump For PRs that when merged do not need a bump in version number.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants