Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop generating empty input/output structs (query, headers, ...) #235

Merged

Conversation

czechboy0
Copy link
Collaborator

Motivation

Fixes #229.

Modifications

Stops generating the structs and properties when they're empty.

Result

About 10% reduction in generated code, more clear generated code.

Test Plan

Adapted tests, check those out first to see how the generated code is changing.

Copy link
Contributor

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@czechboy0 czechboy0 merged commit 6a81c26 into apple:main Aug 31, 2023
5 of 6 checks passed
@czechboy0 czechboy0 deleted the hd-skip-generating-empty-input-output-structs branch August 31, 2023 10:09
@czechboy0 czechboy0 added the semver/minor Adds new public API. label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/minor Adds new public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider not generating empty input/output structs (e.g. paths, query, etc)
2 participants