Disable "respectsExistingLineBreaks" in .swift-format for more consistent styling #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to revert the changes from the previous PR because there were too many conflicts. I've been waiting for the PR section to be empty. |
czechboy0
requested changes
Oct 25, 2023
There was a problem hiding this comment.
Just two comments, otherwise looks great, thank you @PARAIPAN9!
If you have more time, it'd be great to apply the same change to the other 3 repos, we want to keep all 4 consistent.
Examples/GreetingServiceClient/Sources/GreetingServiceClient/GreetingServiceClient.swift
Outdated
Show resolved
Hide resolved
|
Still seems the symlink got changed, unless github is slow to refresh the diff. |
|
Yes, I see... |
|
Please make sure you're running swift-format 5.9, as the CI is disagreeing on the formatting. |
|
I was on -v 5.8, I've just updated to the latest version and addressed the complaints. |
czechboy0
approved these changes
Oct 25, 2023
|
Great, thank you @PARAIPAN9! I think the other 3 repos will be easier 🙂 |
|
You're welcome, I'm pretty sure too 😄. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Result
Test Plan