Safe server variable names when used in Swift identifiers #351
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the original introduction of server variable support, we didn't properly safe the variable names coming from the OpenAPI document for use as Swift identifiers.
Modifications
Fix that by running the name server variable name, provided in the OpenAPI document, through the function that safes the string for use as a Swift identifier.
Result
Documents that use variable names like
protocol
compile again.Test Plan
Adapted the tests.