Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Issues with Async Upstream #108

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Fixing Issues with Async Upstream #108

merged 5 commits into from
Jul 2, 2024

Conversation

leogdion
Copy link
Contributor

Motivation

Fixing Issues with Building in Swift 6 for Linux

Modifications

  • Fix Issues with Upstream Iterator

Result

Compatability with Swift 6 on Linux

Test Plan

TBD

@leogdion leogdion mentioned this pull request Jun 21, 2024
Draft
@czechboy0
Copy link
Collaborator

Thanks @leogdion! Please run the soundness script, the indentation seems to be off here. It'll run swift-format and fix it up for you.

@leogdion
Copy link
Contributor Author

Apologies @czechboy0 - Fix is pushed.

@czechboy0
Copy link
Collaborator

@swift-server-bot test this please

@czechboy0
Copy link
Collaborator

@leogdion Apologies, I didn't realize the utility method strategy won't really work on older toolchains. Can you please revert it and I'll kick off CI again?

@leogdion
Copy link
Contributor Author

Reverted

@czechboy0
Copy link
Collaborator

@swift-server-bot test this please

@czechboy0
Copy link
Collaborator

@leogdion I think if you put the #available( into the #if compiler check, hopefully the platform should be known and it should fix the CI?

@leogdion
Copy link
Contributor Author

leogdion commented Jul 2, 2024

@leogdion I think if you put the #available( into the #if compiler check, hopefully the platform should be known and it should fix the CI?

Fixed

@leogdion
Copy link
Contributor Author

leogdion commented Jul 2, 2024

@swift-server-bot test this please

1 similar comment
@czechboy0
Copy link
Collaborator

@swift-server-bot test this please

czechboy0
czechboy0 approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@czechboy0 czechboy0 merged commit e80046b into apple:main Jul 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czechboy0 czechboy0 czechboy0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leogdion @czechboy0