[Runtime] Generate server variables #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
approved these changes
Oct 26, 2023
czechboy0
added a commit
to apple/swift-openapi-generator
that referenced
this pull request
Oct 26, 2023
[Generator] Generate server variables ### Motivation The generator side of #24. Depends on apple/swift-openapi-runtime#64 landing and getting released. ### Modifications See the file-based reference tests first to get a sense of how server variables work in templates. Most of this PR is test changes, plus slightly changed formatting of arrays, to put each item on new line for non-empty ones. ### Result Server variables are supported, allowing e.g. services that have enterprise versions to use the feature instead of having to hardcode the remote URL. ### Test Plan Adapted tests. Reviewed by: glbrntt Builds: ✔︎ pull request validation (5.10) - Build finished. ✔︎ pull request validation (5.8) - Build finished. ✔︎ pull request validation (5.9) - Build finished. ✔︎ pull request validation (compatibility test) - Build finished. ✔︎ pull request validation (docc test) - Build finished. ✔︎ pull request validation (integration test) - Build finished. ✔︎ pull request validation (nightly) - Build finished. ✔︎ pull request validation (soundness) - Build finished. #348
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The runtime side of apple/swift-openapi-generator#24.
Modifications
Added an SPI
ServerVariabletype and a variant of theURL.init(validatingOpenAPIServerURL:variables:)method, which takes the template and variables and returns a fully formed concrete URL.Result
Unblocked the generator half of supporting server variables.
Test Plan
Added unit tests.