Make setting HTTPBody.iteratorCreated thread-safe #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes apple/swift-openapi-generator#502
HTTPBody.collect(upTo)
.makeAsyncIterator()
: Instead of crashing, return AsyncSequence which throwsTooManyIterationsError
thereby honoring the contract forIterationBehavior.single
(HTTPBody, MultipartBody)Modifications
makeAsyncIterator()
: removedtry!
, catch error and create a sequence which throws the error on iteration.try checkIfCanCreateIterator()
inHTTPBody.collect(upTo)
.Note: This creates a small change in behavior: There may be a
TooManyBytesError
thrown before the check foriterationBehavior
. This approach uses the simplest code, IMO. If we want to keep thatiterationBehavior
is checked first and only after that for the length, then the code needs to be more complex.try checkIfCanCreateIterator()
in both classes (only used inHTTPBody
).Result
makeAsyncIterator()
anymore.Test Plan
Test_Body.testIterationBehavior_single()
to ensure that usingmakeAsyncIterator()
directly yields the expected error.MultipartBody
.