-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider supporting version ranges in evolution page search fragment #296
Comments
I just stumbled on this when I was working on #369. There are a few blog articles that link to the old github pages Swift Evolution site
That's no longer the case. It redirects to the To fix the broken links, I thought I can just link to I'm not actively working in this. But, once this is solved, we can clean out a few of those old links. |
The version filter query string is present at http://www.swift.org/swift-evolution. For example: This issue is to consider enhancing the existing query string functionality to include handling ranges of versions. You should be able to update links pointing to the previous evolution page location to the new URL, including the query strings. If one or more query strings from an old evolution URL doesn’t work, please file a separate issue. |
@dempseyatgithub Range support in the URL query is definitely a nice-to-have. Are there any links on the site that would be shortened if this gets implemented? I am fine with moving forward with it either way, just curious if there are any immediate applications. |
@kaishin A use case I was thinking about was being able to have a URL that would filter to all the upcoming feature flags of a given major version. So, it’s more a URL that is not currently expressible. But a plain range doesn’t solve this problem as nicely as it could, since the URL would constantly need to be updated to include the end of the range. Thinking about his further, I think maybe instead of adding support for a range there are two things we might consider adding:
This would allow for an ‘evergreen’ URL to link to the UFFs that are valid in the current major version:
I like the compactness of Maybe
The more I think about it, the more I think that option 1 ( With option 2, any link that tried to lead developers to the currently valid list of upcoming feature flags would need to be updated with every major release. |
@dempseyatgithub I like the idea of supporting
That would be my vote as well. Let's get green light on this from the workgroup before we proceed! |
Yes. It will probably be over the holidays, but I'll flesh this out into more specific proposal. |
Currently, on the evolution dashboard page, search queries as well as all filters generate and accept a fragment in the URL that defines the search.
For example searching for proposals with the word ’regex’ that are Implemented:
http://www.swift.org/swift-evolution/#?status=implemented&search=regex
This is also true of the Swift version filters for implemented proposals:
http://www.swift.org/swift-evolution/#?version=5.3,5.4,5.5
The comma-separated list of versions can get cumbersome and long, especially when trying to express a range of releases.
For example a link that will show all proposals with an upcoming feature flag that is valid in Swift 5.8 would be:
https://www.swift.org/swift-evolution/#?version=5,5.1,5.2,5.3,5.4,5.5,5.5.2,5.6,5.7,5.8&upcoming=true
It would be useful if the version could accept a range of versions in addition to individual versions.
https://www.swift.org/swift-evolution/#?version=5.1-5.8&upcoming=true
Multiple individual versions and version ranges can be used and combined separated by a comma:
https://www.swift.org/swift-evolution/#?version=2.2-3,4.2,5.1-5.8&upcoming=true
I have an implementation of this but wanted to open this issue to discuss before opening a PR.
The text was updated successfully, but these errors were encountered: