-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for broken links in the CI test job #369
Open
natikgadzhi
wants to merge
12
commits into
swiftlang:main
Choose a base branch
from
natikgadzhi:internal/ci-htmlproofer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Sep 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0317303 - Browse repository at this point
Copy the full SHA 0317303View commit details -
Configuration menu - View commit details
-
Copy full SHA for 349397c - Browse repository at this point
Copy the full SHA 349397cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef5fdc6 - Browse repository at this point
Copy the full SHA ef5fdc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34500a2 - Browse repository at this point
Copy the full SHA 34500a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 374e480 - Browse repository at this point
Copy the full SHA 374e480View commit details -
Configuration menu - View commit details
-
Copy full SHA for 557f237 - Browse repository at this point
Copy the full SHA 557f237View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0152b15 - Browse repository at this point
Copy the full SHA 0152b15View commit details -
Configuration menu - View commit details
-
Copy full SHA for cb037aa - Browse repository at this point
Copy the full SHA cb037aaView commit details
Commits on Sep 16, 2023
-
Fixed #swift-evolution menu item and 4 more links
This commit fixes 4 more broken links: the navigation menu item, the reference-less link, and two other blog posts. The `_navigation.yml` and several pages linked to `/contributing/#evolution-process`, and we had an `<a>` tag with `name="evolution-process"`, which is invalid in `htmlproofer`s eyes because it's a link that does not have a reference. Jekyll makes `id`s for every heading automatically, and we have `/contributing/#swift-evolution` that we should link to instead.
Configuration menu - View commit details
-
Copy full SHA for e23cf00 - Browse repository at this point
Copy the full SHA e23cf00View commit details -
Ignore link check to /404.html
The 404.html page renders with HTTP404 code, but that's valid. Hence, we should ignore that page in `check_links.sh`
Configuration menu - View commit details
-
Copy full SHA for ebeb0c1 - Browse repository at this point
Copy the full SHA ebeb0c1View commit details
Commits on Sep 17, 2023
-
Allow <a> without href attribute in link check
We have just one link without the `href` attribute, which is a button in the Swift Evolutions browser. We know it's valid, and the case where `<a>` tags won't have `href`s is rare, so we can safely ignore them in the check.
Configuration menu - View commit details
-
Copy full SHA for 858632c - Browse repository at this point
Copy the full SHA 858632cView commit details -
Add
htmlproofer
inGemfile.lock
In 0317303, I've added `htmlproofer` to `Gemfile`, but did not commit the changes to `Gemfile.lock`. This commit adds it back.
Configuration menu - View commit details
-
Copy full SHA for 42a8209 - Browse repository at this point
Copy the full SHA 42a8209View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.