Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for broken links in the CI test job #369

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Commits on Sep 15, 2023

  1. Configuration menu
    Copy the full SHA
    0317303 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    349397c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ef5fdc6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    34500a2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    374e480 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    557f237 View commit details
    Browse the repository at this point in the history
  7. Fix broken links

    natikgadzhi committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    0152b15 View commit details
    Browse the repository at this point in the history
  8. Fix broken Xcode links

    natikgadzhi committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    cb037aa View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2023

  1. Fixed #swift-evolution menu item and 4 more links

    This commit fixes 4 more broken links: the navigation menu item,
    the reference-less link, and two other blog posts.
    
    The `_navigation.yml` and several pages linked to
    `/contributing/#evolution-process`, and we had an `<a>` tag with
    `name="evolution-process"`, which is invalid in `htmlproofer`s eyes
    because it's a link that does not have a reference.
    
    Jekyll makes `id`s for every heading automatically, and we have
    `/contributing/#swift-evolution` that we should link to instead.
    natikgadzhi committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    e23cf00 View commit details
    Browse the repository at this point in the history
  2. Ignore link check to /404.html

    The 404.html page renders with HTTP404 code, but that's valid. Hence, we
    should ignore that page in `check_links.sh`
    natikgadzhi committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    ebeb0c1 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2023

  1. Allow <a> without href attribute in link check

    We have just one link without the `href` attribute, which is a button in
    the Swift Evolutions browser. We know it's valid, and the case where `<a>`
    tags won't have `href`s is rare, so we can safely ignore them in the
    check.
    natikgadzhi committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    858632c View commit details
    Browse the repository at this point in the history
  2. Add htmlproofer in Gemfile.lock

    In 0317303, I've added `htmlproofer` to
    `Gemfile`, but did not commit the changes to `Gemfile.lock`. This commit
    adds it back.
    natikgadzhi committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    42a8209 View commit details
    Browse the repository at this point in the history