Prefer linking to GitHub profiles in blog post bylines #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Link to GitHub profile if present, to Twitter profile as fallback, reversing the current order - Better supports viewing profile info even if not logged-in - Changes to Twitter/X now require being logged-in to see profile info - GitHub displays profile info even when not logged info
dempseyatgithub
requested review from
0xTim,
alexandersandberg,
daveverwer,
parispittman,
kaishin,
mschinis,
shahmishal,
TimTr,
tomerd and
cthielen
as code owners
alexandersandberg
approved these changes
Sep 21, 2023
|
@swift-ci test |
We currently have GitHub info for all authors except for three. We would need to gather Swift forum info for all authors. One reason I think GitHub profile pages are preferable is that they have dedicated fields for users to provide various means of contact or connection: URL, email, multiple social media handles. The Swift Forums profile only provides a field for a URL. I would also guess that developers are more likely to curate their GitHub profile than their Swift forum profile, but that’s just a guess. |
0xTim
approved these changes
Sep 21, 2023
This was referenced Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverses the preference order of the link used in blog post bylines.
This change will link to the author’s GitHub profile if present, then fall back to link to the Twitter/X profile if present, finally displaying no link if neither is present.
Twitter/X now requires being logged-in to view profile information. GitHub displays profile information without being logged-in. This change provides a better experience by not requiring a user to be logged into any service to view the profile information linked from a blog post byline.
The change is minor, changing the order in which presence of the account info is checked. I’ve tested this on a local copy of the site.