[Xcodeproj] Add dummy target to provide autocomplete in the manifest … #1266
Conversation
aciidgh
force-pushed
the
auto-complete-spx
branch
2 times, most recently
from
3cae50a
to
4922873
Compare
| try Process.checkNonZeroExit( | ||
| args: "xcodebuild", "-project", project.asString, "-alltargets", environment: env) | ||
| args: "xcodebuild", "-project", project.asString, "-scheme", schemeName, "-derivedDataPath", buildDir, environment: env) |
There was a problem hiding this comment.
Can we have a test that checks that the dummy target builds, by passing -target? That way we can validate it is configured properly.
Also, should we put all manifests in it, as opposed to just the one from the primary package?
There was a problem hiding this comment.
The target doesn't build, it fails with linking errors. Only autocompletion works.
I wouldn't want to put dependency manifests because we don't want people editing them without the edit mode.
There was a problem hiding this comment.
Should we put in all ones that are in edit mode then?
As for the linking think, we might be able to do a hack like set LD and/or LDPLUSPLUS to be /usr/bin/true for that one target.
There was a problem hiding this comment.
Ya I think putting references of the edited manifests will be fine.
There was a problem hiding this comment.
I ended up adding manifest reference for all dependencies because it will be non trivial to compute edited dependencies outside of Workspace. I think it should be fine to add manifest references of non-edited packages as we add their source files anyway.
aciidgh
force-pushed
the
auto-complete-spx
branch
2 times, most recently
from
b7009c7
to
a3817f0
Compare
|
@swift-ci please smoke test |
aciidgh
force-pushed
the
auto-complete-spx
branch
from
a3817f0
to
bab15d8
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
aciidgh
force-pushed
the
auto-complete-spx
branch
from
bab15d8
to
f9d7622
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
aciidgh
force-pushed
the
auto-complete-spx
branch
2 times, most recently
from
182399e
to
094432f
Compare
|
@swift-ci please smoke test OS X |
|
@swift-ci please smoke test |
…file -- <rdar://problem/33284557> Create dummy target in generated Xcode project to provide autocompletion for the manifest file
aciidgh
force-pushed
the
auto-complete-spx
branch
from
094432f
to
4899c83
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
+1: Awesome! |
…file