Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SimpleProgressBar for dumb terminals #1489

Merged
merged 2 commits into from
Feb 10, 2018
Merged

Add SimpleProgressBar for dumb terminals #1489

merged 2 commits into from
Feb 10, 2018

Conversation

aciidgh
Copy link
Member

@aciidgh aciidgh commented Feb 10, 2018

No description provided.

@aciidgh aciidgh requested a review from ddunbar February 10, 2018 06:40
ddunbar
ddunbar approved these changes Feb 10, 2018
View reviewed changes
Copy link
Member

@ddunbar ddunbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, although I didn't review very closely.

I think we might want both, though... when piped to a file, it is probably more appropriate to show the one-line-per-test output?

@aciidgh
Copy link
Member Author

aciidgh commented Feb 10, 2018

IDK, don't think it matters a lot. We display the output of test failures anyway.

@aciidgh
Copy link
Member Author

aciidgh commented Feb 10, 2018

@swift-ci please smoke test

@ddunbar
Copy link
Member

ddunbar commented Feb 10, 2018

One place it tends to matter is when running things on CI, where it can be nice to see the names of tests scroll by, and there is little value in compressing onto a single line.

@aciidgh
Copy link
Member Author

aciidgh commented Feb 10, 2018

Hm, how about SingleLine when its a dumb TERM and SimpleProgress when its a non-tty?

@ddunbar
Copy link
Member

ddunbar commented Feb 10, 2018

@aciidb0mb3r yeah exactly

@aciidgh aciidgh force-pushed the emacs-vs-vim branch 2 times, most recently from 429a688 to bd0b895 Compare February 10, 2018 07:35
@aciidgh
Copy link
Member Author

aciidgh commented Feb 10, 2018

@swift-ci please smoke test

@aciidgh
[Utility] Add SingleLineProgressBar
7902eec 
This progress bar is visually better if the terminal is "dumb".
@aciidgh
Copy link
Member Author

aciidgh commented Feb 10, 2018

@swift-ci please smoke test

@aciidgh aciidgh changed the title Replace SimpleProgressBar with SingleLineProgressBar Add SimpleProgressBar for dumb terminals Feb 10, 2018
@aciidgh aciidgh merged commit c52d810 into apple:master Feb 10, 2018
@aciidgh aciidgh deleted the emacs-vs-vim branch February 10, 2018 08:02
@Yasumoto Yasumoto mentioned this pull request Aug 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddunbar ddunbar ddunbar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aciidgh @ddunbar