[Workspace] Add tests in executable template #1610
Conversation
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
<rdar://problem/36554558> Default executable SwiftPM package should have tests
|
@swift-ci please smoke test |
| for bundle in Bundle.allBundles where bundle.bundlePath.hasSuffix(".xctest") { | ||
| return bundle.bundleURL.deletingLastPathComponent() | ||
| } | ||
| fatalError() |
There was a problem hiding this comment.
Could we add a comment to the fatalError? fatalError("Couldn't find the products directory")
There was a problem hiding this comment.
Why aren't we doing the same thing SwiftPMProduct is doing on Linux?
return AbsolutePath(CommandLine.arguments.first!, relativeTo: currentWorkingDirectory)
.parentDirectory.appending(self.exec)
There was a problem hiding this comment.
Most likely because it wasn't implemented at the time.
| // Use XCTAssert and related functions to verify your tests produce the correct | ||
| // results. | ||
|
|
||
| guard #available(macOS 10.13, *) else { |
There was a problem hiding this comment.
I think users who init this might be wondering why it's guarded with mac availability. I think we need to put a comment.
| return | ||
| } | ||
|
|
||
| let fooBinary = productsDirectory.appendingPathComponent("foo") |
There was a problem hiding this comment.
I think it would be great to move the whole code that runs an executable into a function to encourage people to continue with that in other tests.
There was a problem hiding this comment.
I explicitly don't want to do that because then its wrapping NSProcess and it would be difficult to create a correct wrapper while keeping the sample code small.
rdar://problem/36554558 Default executable SwiftPM package should have tests