[SR-7828] Add name-based fixits to product dependencies name #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will be very cool to add! We should make the implementation a bit smart to only suggest things when it makes sense. You can take a look at this method from compiler for some inspiration https://github.com/apple/swift/blob/876738fabe1218b824f26b665f8808c18c0a7513/lib/Sema/TypeCheckNameLookup.cpp#L579-L607 |
|
Closing due to inactivity, feel free to update and reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "did you mean ___ ?" when a product dependency cannot be found.
Please check my implementation with map and reduce, I am not sure if that is perfectly correct (in terms of readability, guidelines, etc).