[Build] Clarify BuildPlan.Error.missingLinuxMain
#1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it clear that LinuxMain.swift must be at the top level. [SR-8646] BuildPlan.Error.missingLinuxMain description rephrasing
ankitspd
reviewed
Jan 2, 2019
Sources/Build/BuildPlan.swift
Outdated
| @@ -788,7 +788,7 @@ public class BuildPlan { | |||
| public var description: String { | |||
| switch self { | |||
| case .missingLinuxMain: | |||
| return "missing LinuxMain.swift file" | |||
| return "missing LinuxMain.swift file at top level" | |||
There was a problem hiding this comment.
It would be more clear to say something like "missing LinuxMain.swift file in the Tests directory"
Make it clear that LinuxMain.swift must be in the Tests directory, rather than just an arbitrary "top level". [SR-8646] BuildPlan.Error.missingLinuxMain description rephrasing
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SR-8646] BuildPlan.Error.missingLinuxMain description rephrasing
Make it clear that LinuxMain.swift must be at the top level of the Tests directory.
Tests do not appear to quote error messages.