[Commands] Add preliminary support for swift-format #2024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds just a simple `swift package format` command to format all the sources in your root package. The swift-format binary will be looked up using the env variable SWIFT_FORMAT_EXEC. This patch is just for testing the proposed swift-format tool. We will need to figure out the specifics of the integration if/when the proposal is accepted.
| case .format: | ||
| // Look for swift-format binary. | ||
| // FIXME: This should be moved to user toolchain. | ||
| guard let swiftFormat = lookupExecutablePath(filename: getenv("SWIFT_FORMAT_EXEC")) else { |
There was a problem hiding this comment.
Toolchain comes with swift-format that could be used by default here
|
@swift-ci smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds just a simple
swift package formatcommand to format all thesources in your root package. The swift-format binary will be looked up
using the env variable SWIFT_FORMAT_EXEC.
This patch is just for testing the proposed swift-format tool. We will
need to figure out the specifics of the integration if/when the proposal
is accepted.