Compile manifests instead of interpreting them #2518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
hartbit
force-pushed
the
compile-manifests
branch
from
0f5247e
to
d9958ba
Compare
|
@swift-ci smoke test |
hartbit
force-pushed
the
compile-manifests
branch
from
d9958ba
to
7add6a2
Compare
|
@swift-ci smoke test |
|
@aciidb0mb3r Do you have an idea what is causing the failures on Linux? I haven't been able to reproduce them in Docker. |
|
@swift-ci smoke test Linux |
ankitspd
reviewed
Jan 15, 2020
|
For linux, can you try reproducing by installing the toolchain in some other directory instead of system's /usr? I think it's somehow looking for the swift runtime object at the default path instead of the toolchain 🤔 |
|
But that wouldn't be causing the exact same issue for Linux self hosted? |
hartbit
force-pushed
the
compile-manifests
branch
from
7add6a2
to
e8db9f4
Compare
|
@swift-ci smoke test |
hartbit
force-pushed
the
compile-manifests
branch
from
e8db9f4
to
2cf7cc7
Compare
|
@swift-ci smoke test self hosted |
ankitspd
force-pushed
the
compile-manifests
branch
from
2cf7cc7
to
76a03ae
Compare
|
@swift-ci smoke test self hosted |
<rdar://problem/58028627>
ankitspd
force-pushed
the
compile-manifests
branch
from
76a03ae
to
186e424
Compare
|
@swift-ci smoke test |
This was referenced Jan 23, 2020
|
Hi, I could not find the reason behind this change - is it a question of performance or is there something else? |
|
It’s a question of portability. The interpreter is usually much less stable on other platforms than the compiler.
… On 7 Feb 2020, at 08:07, Marek Fořt ***@***.***> wrote:
Hi, I could not find the reason behind this change - is it a question of performance or is there something else?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
neonichu
added a commit
to neonichu/swift-package-manager
that referenced
this pull request
Aug 5, 2020
Manifest loading has been sandboxed on macOS for a while, but the change in apple#2518 broke it for 5.3. https://bugs.swift.org/browse/SR-13346 rdar://problem/66586184
neonichu
added a commit
that referenced
this pull request
Aug 6, 2020
* Reinstate manifest sandboxing Manifest loading has been sandboxed on macOS for a while, but the change in #2518 broke it for 5.3. https://bugs.swift.org/browse/SR-13346 rdar://problem/66586184 * Test manifest sandboxing This adds tests for manifest sandboxing. Since we made the sandbox more restrictive in 5.3, there are two tests: - in 5.2 we check if we can make a network request - in 5.3 we check if we can launch a process * Fix 5.3 sandbox profile * Use 127.0.0.1 for the attempted network request It doesn't actually matter whether or not the request would succeed since the test assumes it will always be blocked.
neonichu
added a commit
to neonichu/swift-package-manager
that referenced
this pull request
Aug 6, 2020
Manifest loading has been sandboxed on macOS for a while, but the change in apple#2518 broke it for 5.3. https://bugs.swift.org/browse/SR-13346 rdar://problem/66586184 (cherry picked from commit 4d720d6)
neonichu
added a commit
that referenced
this pull request
Aug 7, 2020
Manifest loading has been sandboxed on macOS for a while, but the change in #2518 broke it for 5.3. https://bugs.swift.org/browse/SR-13346 rdar://problem/66586184 (cherry picked from commit 4d720d6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice that this change requires modifications to
bootstrapandManifestLoaderto make sure the compiled manifest can find the dynamicPackageDescriptionruntime library.