[PackageLoading] Better handling for directories with extension #2571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
ankitspd
force-pushed
the
dot-in-the-house-5.2
branch
from
44d4749
to
5080639
Compare
|
@swift-ci smoke test |
Package builder started considering directories inside a target as a file that can have a rule. However, this wasn't gated behind the tools version check and we were not handling directories that are explicitly declared as sources in the package manifest. <rdar://problem/59243977> (cherry picked from commit 1e15bbb)
ankitspd
force-pushed
the
dot-in-the-house-5.2
branch
from
5080639
to
7a93fc0
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test macOS |
1 similar comment
|
@swift-ci smoke test macOS |
|
@swift-ci test macOS |
|
@swift-ci please test |
|
Merging as we got macOS coverage using full swift-ci testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package builder started considering directories inside a target as
a file that can have a rule. However, this wasn't gated behind the tools
version check and we were not handling directories that are explicitly
declared as sources in the package manifest.
rdar://problem/59243977
https://bugs.swift.org/browse/SR-12158
(cherry picked from commit 1e15bbb)