Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass -static-stdlib for all compiler jobs #3048

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 19 additions & 1 deletion Sources/Build/BuildPlan.swift
Original file line number Diff line number Diff line change
Expand Up @@ -642,6 +642,7 @@ public final class SwiftTargetBuildDescription {
args += activeCompilationConditions
args += additionalFlags
args += moduleCacheArgs
args += stdlibArguments
args += buildParameters.sanitizers.compileSwiftFlags()
args += ["-parseable-output"]

Expand Down Expand Up @@ -763,6 +764,7 @@ public final class SwiftTargetBuildDescription {
result += activeCompilationConditions
result += additionalFlags
result += moduleCacheArgs
result += stdlibArguments
result += self.buildSettingsFlags()

return result
Expand Down Expand Up @@ -811,6 +813,7 @@ public final class SwiftTargetBuildDescription {
result += activeCompilationConditions
result += additionalFlags
result += moduleCacheArgs
result += stdlibArguments
result += buildParameters.sanitizers.compileSwiftFlags()
result += ["-parseable-output"]
result += self.buildSettingsFlags()
Expand Down Expand Up @@ -976,6 +979,15 @@ public final class SwiftTargetBuildDescription {
private var moduleCacheArgs: [String] {
return ["-module-cache-path", buildParameters.moduleCache.pathString]
}

private var stdlibArguments: [String] {
if buildParameters.shouldLinkStaticSwiftStdlib &&
buildParameters.triple.isSupportingStaticStdlib {
return ["-static-stdlib"]
} else {
return []
}
}
}

/// The build description for a product.
Expand Down Expand Up @@ -1105,7 +1117,7 @@ public final class ProductBuildDescription {
if buildParameters.shouldLinkStaticSwiftStdlib {
if buildParameters.triple.isDarwin() {
diagnostics.emit(.swiftBackDeployError)
} else if buildParameters.triple.isLinux() || buildParameters.triple.arch == .wasm32 {
} else if buildParameters.triple.isSupportingStaticStdlib {
args += ["-static-stdlib"]
}
}
Expand Down Expand Up @@ -1908,3 +1920,9 @@ fileprivate extension Triple.OS {
}
}
}

fileprivate extension Triple {
var isSupportingStaticStdlib: Bool {
isLinux() || arch == .wasm32
}
}
37 changes: 37 additions & 0 deletions Tests/BuildTests/BuildPlanTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -2421,6 +2421,43 @@ final class BuildPlanTests: XCTestCase {
])
}

func testShouldLinkStaticSwiftStdlib() throws {
let fs = InMemoryFileSystem(emptyFiles:
"/Pkg/Sources/exe/main.swift",
"/Pkg/Sources/lib/lib.swift"
)

let diagnostics = DiagnosticsEngine()
let graph = loadPackageGraph(fs: fs, diagnostics: diagnostics,
manifests: [
Manifest.createV4Manifest(
name: "Pkg",
path: "/Pkg",
url: "/Pkg",
packageKind: .root,
targets: [
TargetDescription(name: "exe", dependencies: ["lib"]),
TargetDescription(name: "lib", dependencies: []),
]),
]
)

let supportingTriples: [TSCUtility.Triple] = [.x86_64Linux, .arm64Linux, .wasi]
for triple in supportingTriples {
let result = BuildPlanResult(plan: try BuildPlan(
buildParameters: mockBuildParameters(shouldLinkStaticSwiftStdlib: true, destinationTriple: triple),
graph: graph, diagnostics: diagnostics, fileSystem: fs)
)

let exe = try result.target(for: "exe").swiftTarget().compileArguments()
XCTAssertTrue(exe.contains("-static-stdlib"))
let lib = try result.target(for: "lib").swiftTarget().compileArguments()
XCTAssertTrue(lib.contains("-static-stdlib"))
let link = try result.buildProduct(for: "exe").linkArguments()
XCTAssertTrue(link.contains("-static-stdlib"))
}
}

func testBinaryTargets(platform: String, arch: String, destinationTriple: TSCUtility.Triple)
throws {
let fs = InMemoryFileSystem(emptyFiles:
Expand Down