Add pkgconfig args in Xcodeproj generation #306
Conversation
|
we need to have |
|
Looks like either OTHER_CFLAGS or OTHER_SWIFT_FLAGS prefixed with -Xcc does the job. I chose the first one because it seems cleaner that way. |
| } | ||
|
|
||
| public func pkgConfigArgs() throws -> (xcc: [String], xld: [String]) { | ||
| var xcc = [String]() |
There was a problem hiding this comment.
If we are going to use Xcc as the name in the code, we should case it consistently.
|
@aciidb0mb3r Ping, can I help out here somehow? I'd really like to get this in 😊 |
|
Hmm we can probably do the linker flags as a separate ticket if @ddunbar is fine with it. Rest of the comments are pretty small. |
|
Awesome, yeah I agree that the linker flag filtering/auditing should come as a separate PR, because it's not specific to the xcode project generation. |
ankitspd
force-pushed
the
xcode-pkgconfig
branch
2 times, most recently
from
0cb7104
to
34e36f3
Compare
|
@ddunbar Updated the PR, please re-review. Will do the filtering of flags etc in separate PR |
|
Ok, I am willing to take this since it seems like a monotonic improvement. I am however pretty concerned about our lack of tests here... |
|
@swift-ci please test and merge |
ankitspd
force-pushed
the
xcode-pkgconfig
branch
2 times, most recently
from
a777a17
to
79e956e
Compare
…ate xcodeproj with pkgconfig flags
|
@swift-ci please test and merge |
|
@ddunbar can you suggest how to go about testing this? |
Properly detach signal handler thread
Fixes https://bugs.swift.org/browse/SR-1368