Transmute refactor #308
Closed
Transmute refactor #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,7 +26,8 @@ public class Options { | |||
| set { _build = newValue } | |||
| } | |||
|
|
|||
| private var _build = getenv("SWIFT_BUILD_PATH") | |||
| private var _Packages: String? | |||
| private var _build: String? | |||
We have --build-path now.
Fixes a few exclude bugs in the process. Extensions were not sufficient, needed a “manager” for the process.
|
@ddunbar you ok with this? |
|
@swift-ci Please test |
| import Utility | ||
|
|
||
|
|
||
| class Apparatus { |
There was a problem hiding this comment.
What is the purpose of this class? Can we get a doc-comment here?
|
Sorry, I missed the question here... the changes seem ok to me but I'm not clear what conceptual role |
|
Closing this out while we figure out the right answer here... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing for
--editimplementation