fix a bug in test discovery where tests defined in extensions break the discovery #3433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
requested review from
abertelrud,
friedbunny and
neonichu
as code owners
tomerd
changed the title
tomerd
changed the title
…e discovery motivation: less bugs, happier users changes: modify test discovery code to key of class name rather than blindly iterate over tetst rdar://58435666
|
@swift-ci please smoke test |
tomerd
added
the
ready
|
cc @adam-fowler |
neonichu
approved these changes
Apr 23, 2021
tomerd
added a commit
to tomerd/swift-package-manager
that referenced
this pull request
Apr 23, 2021
…e discovery (apple#3433) motivation: less bugs, happier users changes: modify test discovery code to key of class name rather than blindly iterate over tetst rdar://58435666
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: less bugs, happier users
changes: modify test discovery code to key of class name rather than blindly iterate over tetst
rdar://58435666